fix(homebrew): Validate rendered formula quoting - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Homebrew's required double-quoted strings in the Apple Docs formula template so publication no longer fails the tap's style checks. Validate each rendered formula with
brew stylein the existing template tests, catching this before publication.Validation
The new check reproduced all 23 string-literal offenses before the fix.
make test-homebrew, formatting, and pre-commit checks now pass. Fullmake testremains blocked locally by missingrpmbuild.Publication
After merge, rerun publication for
techprimate/apple-docs-cli@v0.0.5to update techprimate/homebrew-tap#8 with the corrected quoting. The executable-permissions fix, revision 1, and release checksums remain unchanged.