Skip to content

Update community page Twitter icon to X - #740

Open
sudhishmk wants to merge 1 commit into
tektoncd:mainfrom
sudhishmk:fix/update-twitter-icon-to-x
Open

Update community page Twitter icon to X#740
sudhishmk wants to merge 1 commit into
tektoncd:mainfrom
sudhishmk:fix/update-twitter-icon-to-x

Conversation

@sudhishmk

Copy link
Copy Markdown

Replace the legacy Twitter icon and link on the community page with current X branding (fa-x-twitter, x.com/tektoncd). Fixes #581

Changes

Update the community page "Reach out" section to use X branding instead of legacy Twitter (icon, link, and label).

Submitter Checklist

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
Update the Twitter icon and link on the community page to X (x.com/tektoncd).

Replace the legacy Twitter icon and link on the community page with
current X branding (fa-x-twitter, x.com/tektoncd).
Fixes tektoncd#581
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign twogiants after the PR has been reviewed.
You can assign the PR to them by writing /assign @twogiants in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2026

@AlanGreene AlanGreene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, however it appears incomplete. The code change doesn't match the PR description.

@@ -38,8 +38,8 @@ <h2>Reach out</h2>
Join the Tekton Slack!</a>
</li>
<li><i class="fab fa-twitter fa-fw"></i>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions that the logo has been updated but it's unchanged here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanGreene Thanks for reviewing it. It seems like the site is shipping older version of Font-Awesome. "fa-x-twitter" was added in Font Awesome 6.4.2 (#19827), so changing only the class name may result in a broken or missing icon even after the URL/text are fixed.

I could see another discussion open for site revamp, so till them may be
we can just update URL + link text now, keep fa-twitter until Font Awesome is upgraded or use an inline SVG?
Alternatively we can bump Font Awesome to ≥ 6.4.2 alongside the branding update.

Let me know your thoughts on this.

@sudhishmk
sudhishmk requested a review from AlanGreene September 9, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update twitter icon on tekton community section

3 participants