Update community page Twitter icon to X - #740
Conversation
Replace the legacy Twitter icon and link on the community page with current X branding (fa-x-twitter, x.com/tektoncd). Fixes tektoncd#581
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
AlanGreene
left a comment
There was a problem hiding this comment.
Thanks for the PR, however it appears incomplete. The code change doesn't match the PR description.
| @@ -38,8 +38,8 @@ <h2>Reach out</h2> | |||
| Join the Tekton Slack!</a> | |||
| </li> | |||
| <li><i class="fab fa-twitter fa-fw"></i> | |||
There was a problem hiding this comment.
The PR description mentions that the logo has been updated but it's unchanged here.
There was a problem hiding this comment.
@AlanGreene Thanks for reviewing it. It seems like the site is shipping older version of Font-Awesome. "fa-x-twitter" was added in Font Awesome 6.4.2 (#19827), so changing only the class name may result in a broken or missing icon even after the URL/text are fixed.
I could see another discussion open for site revamp, so till them may be
we can just update URL + link text now, keep fa-twitter until Font Awesome is upgraded or use an inline SVG?
Alternatively we can bump Font Awesome to ≥ 6.4.2 alongside the branding update.
Let me know your thoughts on this.
Replace the legacy Twitter icon and link on the community page with current X branding (fa-x-twitter, x.com/tektoncd). Fixes #581
Changes
Update the community page "Reach out" section to use X branding instead of legacy Twitter (icon, link, and label).
Submitter Checklist