Add link support for Activity and Workflow#298
Merged
Conversation
Quinn-With-Two-Ns
force-pushed
the
NEXUS-530
branch
from
July 20, 2026 17:45
7e314fd to
bf1d79e
Compare
mavemuri
approved these changes
Jul 21, 2026
| rePatternRunID, | ||
| )) | ||
| urlPathWorkflowRE = regexp.MustCompile(fmt.Sprintf( | ||
| `^/namespaces/%s/workflows/%s/%s$`, |
There was a problem hiding this comment.
nit: maybe re-use the urlPathWorkflowTemplate here so its clearer/doesnt drift
Quinn-With-Two-Ns
force-pushed
the
NEXUS-530
branch
from
July 21, 2026 17:18
bf1d79e to
4093f91
Compare
Quinn-With-Two-Ns
force-pushed
the
NEXUS-530
branch
from
July 21, 2026 17:22
4093f91 to
3dcae6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add link support for Activity and Workflow
Why?
So the SDK , CLI, and Server can all share common link handling code
How did you test it?
Potential risks