time skipping supports max skip, polling, describe#835
Draft
feiyang3cat wants to merge 6 commits into
Draft
Conversation
feiyang3cat
commented
Jul 20, 2026
| google.protobuf.Timestamp fast_forward_target_time = 2; | ||
|
|
||
| // The initial skip count. It only propagates across a chain of runs within the same execution. | ||
| int32 initial_skip_count = 3; |
Contributor
Author
There was a problem hiding this comment.
for reviewers: this shall be propagated so that we can stop workflow retry as workflow retry generates a new run instead retrying within the same run
feiyang3cat
force-pushed
the
vts-maxskip-poll
branch
from
July 20, 2026 01:21
085a333 to
67f341b
Compare
feiyang3cat
changed the title
feiyang3cat
commented
Jul 20, 2026
| // | ||
| // If this field is not set, the server applies a large default value (e.g. 100). The default can | ||
| // be changed through dynamic config, and is overridden by this field when set. | ||
| int32 max_skip_per_session = 4; |
Contributor
Author
There was a problem hiding this comment.
we use a per_session max_skip instead of a total/delta max_skip to make this feature easy
the unneeded complexity introduced by other options:
- total: when the value is updated, both the client and server need to read current skip number to decide if the new value is valid and we may need to expose the current skip number
- delta: as we set a default value when the field is not set, if the user set TSC multiple times, delta may silently accumulate the total number to a large number
feiyang3cat
commented
Jul 20, 2026
| // The fast-forward that was active when the poll started reached its target time and completed. | ||
| RESULT_FAST_FORWARD_COMPLETED = 2; | ||
| // No fast-forward was in progress when the poll started, so there was nothing to wait for. | ||
| RESULT_NO_PENDING_FAST_FORWARD = 3; |
Contributor
Author
There was a problem hiding this comment.
also need to add an result of workflow end (status = completed/failed/canceled/TERMINATED/TIMED_OUT)
but we need the whole execution (a chain of runs) to end instead of a single run's status
GregoryTravis
approved these changes
Jul 20, 2026
simvlad
reviewed
Jul 20, 2026
|
|
||
| message PollWorkflowExecutionTimeSkippingResponse { | ||
| enum Result { | ||
| // The poll timed out server-side before any time-skipping state change occurred to fast forward. |
Contributor
There was a problem hiding this comment.
Sound like this should be different than RESULT_UNSPECIFIED, maybe RESULT_TIMED_OUT?
| // In-flight work includes activities, child workflows, Nexus operations, signal/cancel external workflow operations, etc. | ||
| // User timers are not classified as in-flight work and will be skipped over; the virtual clock may also skip to the | ||
| // time point of the registered fast-forward when there is no in-flight work. | ||
| // Every time time is skipped, the skip count is incremented by one; max_skip_per_session bounds the number of skips allowed within a single time-skipping session. |
feiyang3cat
force-pushed
the
vts-maxskip-poll
branch
3 times, most recently
from
July 21, 2026 00:33
9c9afa6 to
d1ea493
Compare
feiyang3cat
force-pushed
the
vts-maxskip-poll
branch
2 times, most recently
from
July 21, 2026 00:41
2a371d8 to
dd493a2
Compare
feiyang3cat
commented
Jul 21, 2026
| google.protobuf.Duration fast_forward = 2; | ||
|
|
||
| // A client-supplied ID that must be set together with `fast_forward`. It is used to poll for | ||
| // fast-forward completion via PollWorkflowExecutionTimeSkipping. |
Contributor
Author
There was a problem hiding this comment.
for reviewers: explicitly making this id required if fast_forward is used for simplicity
feiyang3cat
force-pushed
the
vts-maxskip-poll
branch
from
July 21, 2026 01:23
dd493a2 to
b4113e7
Compare
feiyang3cat
commented
Jul 21, 2026
| // If this field is not set, the server applies a large default value (e.g. 100). The default can | ||
| // be changed through dynamic config, and is overridden by this field when set. | ||
| int32 max_skip_per_session = 4; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
other similar name: "session_max_skip"
feiyang3cat
commented
Jul 21, 2026
| // If the execution is actively trying to skip time automatically when there is a chance, | ||
| // this field will be set to true. If time has stopped skipping either by fast-forward completion, | ||
| // max skip allowed checking, or user configuration, it will be false. | ||
| bool is_running = 2; |
Contributor
Author
There was a problem hiding this comment.
feiyang3cat
force-pushed
the
vts-maxskip-poll
branch
from
July 22, 2026 08:03
b4113e7 to
4d4a582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
TimeSkippingConfigTimeSkippingInfotoDescribeWorkflowExecution(contains virtual current time and running status)PollWorkflowExecutionTimeSkippingfor fast-forward completion