Add GCP min/max scaling options for worker deployment version#1135
Open
zainawaisn wants to merge 2 commits into
Open
Add GCP min/max scaling options for worker deployment version#1135zainawaisn wants to merge 2 commits into
zainawaisn wants to merge 2 commits into
Conversation
|
|
|
Are more coming? or did we agree on just these? Previous discussion was https://temporaltechnologies.slack.com/archives/C05L7RUSK6E/p1784055551940739 I updated https://temporalio.atlassian.net/browse/COM-222 with that data once I found it. |
Author
|
scratch that, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
What changed?
Adds three new (optional) flags
gcp-cloud-run-min-instances,gcp-cloud-run-max-instances, andgcp-cloud-run-initial-instancestocreate-versionandupdate-version-compute-config.Changes
commands.yaml / commands.gen.go: two new flags
(--gcp-cloud-run-min-instances, --gcp-cloud-run-max-instances) on
create-version and update-version-compute-config, plus help text (optional,
must be paired, defaults 0/30) and usage examples.
commands.worker.deployment.go: a new gcpCloudRunScalerDetails helper turns
the flags into the scaling settings sent to the server, and rejects bad input
early (GCP-only, all three required together, and min <= initial <= max).
Both commands use it, and describe-version now shows the settings back in
its JSON and summary output.
tests: unit tests cover the helper's accept/reject cases and the
describe-version display; command-level error cases were added to
TestCreateWorkerDeploymentVersion_Errors. The end-to-end GCP test stays
skipped (needs real GCP resources).
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Creation:
Update existing:
Error checks: