chore(sdk): reject #[workflow(name=...)] for overriding workflow name#1390
Merged
Conversation
Sushisource
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Explicitly throw on additional tokens being passed to
#[workflow]Why?
We already allow name overriding via
#[run(name = "MyName")]and we were just#[workflow]attributes leading to users thinking they set a custom workflow name, but it was just being ignored.Aligning on the run syntax there's not a strong reason to allow for overriding workflow name in multiple places.
Checklist
Closes [Bug]
#[workflow(name = "...")]is silently ignored instead of setting the workflow name #1389How was this tested:
Added failing test in first commit, fixed in second.
Any docs updates needed?
N/A