Fix task slots used metric#1391
Open
Sushisource wants to merge 3 commits into
Open
Conversation
Sushisource
force-pushed
the
sj/fix-task-slots-used-metric
branch
from
7c5a4ab to
e76472d
Compare
chris-olszewski
approved these changes
Jul 10, 2026
Sushisource
force-pushed
the
sj/fix-task-slots-used-metric
branch
from
e76472d to
3c605ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Fixed worker task slot metric accounting when releasing a permit. The drop-time adjustment is now applied only to
worker_task_slots_available, rather than also incrementingworker_task_slots_used.Added an integration test covering an idle autoscaling activity worker with reserved polling slots.
Why?
Released permits were already removed from the extant permit count, but the metric update added one back to both available and used slots. This could leave
worker_task_slots_usedat 1 after all activity work completed, until another reservation updated the gauge.The available-slot adjustment is still necessary because the underlying RAII permit remains alive during its drop callback; it does not apply to used-slot accounting.
Checklist
Closes [Bug] temporal_worker_task_slots_used (sum across worker types) never reaches 0 during inter-activity gaps sdk-python#1489
How was this tested: