Add patch activation callback#1394
Draft
Sushisource wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added an experimental
WorkerOptions::patch_activation_callbackfor native Rust workflows that lets a worker decide whether the first newly encountered, non-replaypatchedcall activates a patch.The callback receives owned, immutable
PatchActivationInputcontaining workflow information and the patch ID. Its boolean decision is memoized for the workflow run. Declined patches returnfalsewithout recording a marker, while replay, existing history markers, and deprecated patches retain their existing behavior.WASM component workflows are intentionally excluded because supporting the host callback there requires a WIT/generated-interface expansion.
This ports the behavior introduced by temporalio/sdk-ruby#481.
Why?
This allows workflow changes using
patchedto roll out gradually without every new-code worker immediately recording a marker that older workers cannot replay.Testing
cargo test -p temporalio-sdk --libcargo test -p temporalio-workflow patch_activationcargo lintcargo test-lintcargo integ-test workflow_tests::patches: 33 cases