clean up auth mode and secret name handling#452
Open
jaypipes wants to merge 1 commit into
Open
Conversation
jaypipes
force-pushed
the
connection-redesign
branch
4 times, most recently
from
July 24, 2026 10:58
6e1153b to
4bac7ce
Compare
This commit is the first of a series that attempts to clean up the Connection CRD and handling of Connection CRs in the client pool and controller packages. This moves the `AuthMode` type out of `internal/clientpool` and into the `api/v1alpha1` package but *does not* add a field to `ConnectionSpec` for auth mode. Instead, we add a `ConnectionSpec.AuthMode()` method that returns the calculate authentication mode after looking at the different fields of `ConnectionSpec`. Similarly, we add a `ConnectionSpec.SecretName()` method that returns the name of the Kubernetes Secret that holds the authentication information for the Connection. We clean up code in clientpool and controller by now calling these methods on `ConnectionSpec`. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
connection-redesign
branch
from
July 24, 2026 11:45
4bac7ce to
3d9ef89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the first of a series that attempts to clean up the Connection CRD and handling of Connection CRs in the client pool and controller packages.
This moves the
AuthModetype out ofinternal/clientpooland into theapi/v1alpha1package but does not add a field toConnectionSpecfor auth mode. Instead, we add aConnectionSpec.AuthMode()method that returns the calculate authentication mode after looking at the different fields ofConnectionSpec. Similarly, we add aConnectionSpec.SecretName()method that returns the name of the Kubernetes Secret that holds the authentication information for the Connection. We clean up code in clientpool and controller by now calling these methods onConnectionSpec.