feat(controller): emit a Warning event on gate/test workflow terminal failure#457
Merged
jaypipes merged 2 commits intoJul 24, 2026
Merged
Conversation
… failure Split out of PR temporalio#448 per review feedback from @jaypipes, who asked for this to land as its own PR since it's orthogonal to the poller-health checking work. Emits a Warning event the first time a gate/test workflow for the target version is observed to have ended in a non-successful terminal state (Failed, Canceled, Terminated, TimedOut). The previous reconcile's recorded status is compared against the freshly-fetched status so the event only fires once per transition, not on every reconcile loop. Related to temporalio#447 / temporalio#50: @carlydf's comment on temporalio#50 calls out surfacing Gate workflow failure in TemporalWorkerDeployment events as in-scope independent of the post-GA rollout-acceptance-testing work.
jaypipes
self-requested a review
July 24, 2026 11:17
jaypipes
approved these changes
Jul 24, 2026
jaypipes
left a comment
jaypipes
left a comment
Contributor
There was a problem hiding this comment.
👍 thanks @wankhede04 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
internal/controller/genstatus.go: addisGateWorkflowTerminalFailureand emit a Warning event (GateWorkflowFailed) the first time a gate/test workflow for the target version is observed to have ended in a non-successful terminal state (Failed,Canceled,Terminated,TimedOut). The previous reconcile's recorded status is compared against the freshly-fetched status so the event only fires once per transition, not on every reconcile loop.internal/controller/util.go: add theReasonGateWorkflowFailedevent reason constant.Why?
Split out of #448 per review feedback from @jaypipes: "I'd love to see this split into two PRs, one that adds the warning event emission for gate workflow failures and another that adds the poller health checking." This PR is the gate-workflow-failure half; #448 now contains only the poller-health-checking work.
Also directly relates to #447 / #50: @carlydf's comment on #50 states "We should surface worker healthcheck error and Gate workflow failure in the TemporalWorkerDeployment events for sure," calling out Gate workflow failure surfacing as in-scope independent of the post-GA rollout-acceptance-testing work.
How was this tested?
gofmt -l .— cleango vet ./...— cleango build ./...— succeedsmake GOLANGCI_LINT_FIX=false GOLANGCI_LINT_BASE_REV=main lint-code— 0 issuesgo test ./internal/controller/...— all passRisks
This is purely additive: one new event-reason constant and one new Warning event emission, with no changes to rollout/reconciliation decision logic or existing status fields.