fix(server): return fresh compose challenges for malformed credentials - #132
Open
crazywriter1 wants to merge 1 commit into
Open
Conversation
ComposeMiddleware now fans out fresh challenges when ParseCredential fails and reissues a matching entry challenge for invalid echoed requests, aligned with ChargeMiddleware and VerifyOrChallenge retry behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WWW-Authenticatechallenges fromComposeMiddlewarewhen a Payment credential is malformed.ParseCredentialfails.ChargeMiddlewareandVerifyOrChallenge.Context
Previously, compose routes returned only a problem+json error for malformed credentials, while the standard charge path returned a fresh retry challenge. Wallet clients had no challenge to retry against on compose-protected routes.
Test plan
go test ./pkg/server/... -run Composego test ./...