Skip to content

Fix change after copy#20

Open
cyangle wants to merge 1 commit intotenderlove:masterfrom
cyangle:fix_copy
Open

Fix change after copy#20
cyangle wants to merge 1 commit intotenderlove:masterfrom
cyangle:fix_copy

Conversation

@cyangle
Copy link
Copy Markdown

@cyangle cyangle commented Aug 21, 2024

Fix copy by deeply copying src object.

@tenderlove
Copy link
Copy Markdown
Owner

Thanks for sending this. Would it be possible to send the test upstream so that all implementations can benefit?

@cyangle
Copy link
Copy Markdown
Author

cyangle commented Aug 22, 2024

@tenderlove I have opened a PR to upstream.

@tenderlove
Copy link
Copy Markdown
Owner

Is there any way we can change this to perform copy on write? I think marshal dumping and loading on every copy is going to be prohibitive in terms of performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants