docs: add Language Support section to smart-explore/SKILL.md (#1651)#1670
docs: add Language Support section to smart-explore/SKILL.md (#1651)#1670thedotmack merged 2 commits intothedotmack:mainfrom
Conversation
…ack#1651) tree-sitter language docs belonged in smart-explore but were absent; this adds the Bundled Languages table (10 languages) with correct placement. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
Summary by CodeRabbit
WalkthroughAdded a "Language Support" section to the smart-explore skill documenting tree-sitter AST parsing, bundled-language mappings, Markdown-specific behavior, and instructions for project-local tree-sitter grammars via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/utils/skill-docs-placement.test.ts (1)
23-32: Broaden assertions to cover the full language table and fallback contractThis test currently checks only 5 language names. Consider asserting all documented bundled languages plus the unsupported-extension fallback sentence to prevent partial doc regressions.
Proposed test hardening
it('smart-explore/SKILL.md lists bundled languages', () => { const content = readFileSync(join(SKILLS_DIR, 'smart-explore/SKILL.md'), 'utf-8'); - // Core languages must be documented - expect(content).toContain('JavaScript'); - expect(content).toContain('TypeScript'); - expect(content).toContain('Python'); - expect(content).toContain('Go'); - expect(content).toContain('Rust'); + const expectedLanguages = [ + 'JavaScript', + 'TypeScript', + 'TSX / JSX', + 'Python', + 'Go', + 'Rust', + 'Ruby', + 'Java', + 'C', + 'C++', + ]; + + for (const language of expectedLanguages) { + expect(content).toContain(language); + } + + expect(content).toContain('Files with unrecognized extensions are parsed as plain text'); });
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugin/skills/smart-explore/SKILL.md`:
- Around line 147-166: The Language Support docs omit the required custom
grammar and markdown guidance: add instructions about the `.claude-mem.json`
custom-grammar file and note how markdown is specially supported (e.g., code
block handling, frontmatter, and which smart_search/smart_outline behaviors
differ) to the Smart-explore Language Support section; specifically update
SKILL.md near the "Bundled Languages" and fallback paragraph to mention the
`.claude-mem.json` custom grammar (what it contains and where to drop it) and a
short "Markdown special support" note describing how markdown files are parsed
differently and which features (smart_outline, smart_unfold, smart_search) are
affected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 408bb155-45b9-4fb3-a909-64d2896aed2a
📒 Files selected for processing (2)
plugin/skills/smart-explore/SKILL.mdtests/utils/skill-docs-placement.test.ts
…rt-explore/SKILL.md - Add Custom Grammars (.claude-mem.json) section explaining how to register additional tree-sitter parsers for unsupported file extensions - Add Markdown Special Support section documenting heading-based outline, code-fence search, section unfold, and frontmatter extraction behaviors - Expand bundled language test to cover all 10 documented languages plus the plain-text fallback sentence to prevent partial doc regressions Co-Authored-By: Claude <noreply@anthropic.com>
|
Addressed in the latest commit: added the Custom Grammars ( |
2 participants
Summary
Fixes #1651
## Language Supportsection toplugin/skills/smart-explore/SKILL.mddocumenting the tree-sitter AST parsing backendVerification
tests/utils/skill-docs-placement.test.ts), all passFiles changed
plugin/skills/smart-explore/SKILL.mdtests/utils/skill-docs-placement.test.tsGenerated by Claude Code
Vibe coded by ousamabenyounes