Preserve blank lines when setting or unsetting dotenv keys - #704
Open
f14114069-del wants to merge 3 commits into
Open
f14114069-del wants to merge 3 commits into
f14114069-del wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating or removing a key currently also removes the blank lines immediately before that assignment. For example, changing
A=oldin# section\n\nA=old\nremoves the separator after the section comment.The parser includes leading whitespace in a binding's original text. Preserve the complete blank lines from that prefix before replacing or deleting the assignment. Indentation on the assignment itself retains the existing behavior.
Adds 24 parametrized regression cases covering both operations, LF and CRLF inputs, whitespace-only separators, duplicate keys, multiline values, quoted keys, and valueless keys. Updates the function docstrings and changelog.
Validation
printenvexecutable.python -m ruff check src tests: passed.python -m ruff format --check src tests: passed (20 files).python -m mypy --platform linux --python-version=3.12 src tests: passed. This checks Linux platform stubs; it is not a Linux runtime test. Native Windows checking encounters the existingos.mkfifotyping error intests/test_fifo_dotenv.py:15.AI disclosure
This patch, its tests, and this description were developed with OpenAI Codex.