fix: find dotenv from direct thread targets - #705
Open
ryanchou1994 wants to merge 2 commits into
Open
ryanchou1994 wants to merge 2 commits into
ryanchou1994 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #531.
When
load_dotenvis used directly as athreading.Threadtarget, the first caller frame belongs to the standard library'sthreadingmodule.find_dotenv()therefore starts its search next tothreading.pyand misses the application's current-directory.env.This change recognizes the actual standard-library module globals by identity and uses the current directory for that direct-target case. Calls through a user wrapper still search relative to the wrapper file, and a user module merely named
threadingis not mistaken for the standard library.Tests cover the direct thread target, wrapper behavior, and the same-name module regression.
Validation: