chore: centralize @types/react-dom version with pnpm catalog#682
Open
Shinyaigeek wants to merge 1 commit into
Open
chore: centralize @types/react-dom version with pnpm catalog#682Shinyaigeek wants to merge 1 commit into
Shinyaigeek wants to merge 1 commit into
Conversation
Add @types/react-dom to the shared pnpm catalog (>=19.0.0, matching @types/react) and reference it from react-ui via the catalog: protocol. This completes the React types set already centralized (@types/react, react, react-dom). Resolved version is unchanged (19.2.3). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Centralize the
@types/react-domversion through the shared pnpm catalog, completing the React types set that is already centralized (@types/react,react,react-dom).@types/react-dom: ">=19.0.0"to thecatalog:inpnpm-workspace.yaml(same range as the existing@types/reactentry).packages/react-uivia thecatalog:protocol instead of the inline>=19.0.0.Why
@types/react,react, andreact-domare already in the catalog, but@types/react-domwas the odd one out, pinned inline inreact-ui. This fills that gap so the React typing versions stay aligned in one place.Scope
Following the established convention in this repo, only
packages/*use thecatalog:protocol;examples/*,docs, andsrc/templates/*intentionally keep their literal ranges.react-uiis the onlypackages/*consumer of@types/react-dom.Notes
19.2.3) — this is a pure centralization with no behavioral impact.pnpm installsucceeds andpnpm --filter @openuidev/react-ui typecheckpasses.🤖 Generated with Claude Code