ConicGradient: add conic sample - #66
Draft
Nor-s wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new ThorVG example demonstrating conic gradients (ported from the existing radial gradient sample) with an interactive seam/angle inspection mode to help validate rendering quality.
Changes:
- Introduces a new
ConicGradientexample rendering multiple shapes with conic gradient fills. - Adds Space-key handling to rotate the conic gradient angle for seam inspection.
- Registers the new example source in the Meson build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/meson.build | Adds ConicGradient.cpp to the example build sources. |
| src/ConicGradient.cpp | New conic gradient example with interactive angle adjustment via Space key. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Port the RadialGradient example to demonstrate conic gradients. - Press Space to inspect the seam and verify the rendering quality. Issue: thorvg/thorvg#4347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: thorvg/thorvg#4347
Screenshot
Screen.Recording.2026-08-24.at.13.25.09.mov