LottieSlot: Gradient sample enhancement - #67
Merged
Merged
Conversation
added gradient geometry and opacity
There was a problem hiding this comment.
Pull request overview
This PR enhances the ThorVG Lottie “slot” example for gradients by expanding the sample slot payload and updating the corresponding Lottie asset so the gradient’s color stops, opacity, and geometry-related properties can be overridden via slots.
Changes:
- Expanded the gradient slot sample JSON in
LottieSlot.cppto include fill stops, opacity, start/end points, height, and angle. - Updated
slot1.jsonto attachsidvalues for the corresponding gradient properties (including opacity and geometry fields).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/LottieSlot.cpp | Extends the gradient slot example payload to cover additional gradient properties. |
| res/lottie/extensions/slot1.json | Updates the gradient fill object to expose more properties via slot sids (opacity/start/end/height/angle). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added gradient geometry and opacity