Skip to content

build: skip Lottie expression examples when unsupported - #69

Closed
Nor-s wants to merge 1 commit into
mainfrom
Nor-s/apply-meson-lottie-expression
Closed

build: skip Lottie expression examples when unsupported#69
Nor-s wants to merge 1 commit into
mainfrom
Nor-s/apply-meson-lottie-expression

Conversation

@Nor-s

@Nor-s Nor-s commented Sep 1, 2026

Copy link
Copy Markdown
Member

Check for Lottie expression support separately from the base Lottie module so non-expression examples can still be built.

image

Check for Lottie expression support separately from the base Lottie
module so non-expression examples can still be built.
Copilot AI lite review requested due to automatic review settings September 1, 2026 14:28
@Nor-s
Nor-s requested review from hermet and tinyjin as code owners September 1, 2026 14:29
@Nor-s Nor-s self-assigned this Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a low-risk build-system adjustment that conditionally compiles optional examples without altering runtime code paths.

Pull request overview

Updates the Meson build logic for the example binaries so that Lottie “expression” examples are only included when the installed ThorVG build exposes expression support, allowing non-expression Lottie examples to still build successfully.

Changes:

  • Removes expression-related example sources from the unconditional Lottie example list.
  • Adds a separate compile/link probe for tvg::LottieAnimation::expressions() and conditionally enables expression examples based on the result.
  • Improves build-time messaging to clarify when expression examples are skipped.
File summaries
File Description
src/meson.build Splits Lottie example enablement into base Lottie vs. expression-capable Lottie, conditionally adding expression example sources.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@hermet hermet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it. LottieAnimation::expressions() is one another runtime example.

@hermet hermet closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants