build: skip Lottie expression examples when unsupported - #69
Closed
Nor-s wants to merge 1 commit into
Closed
Conversation
Check for Lottie expression support separately from the base Lottie module so non-expression examples can still be built.
There was a problem hiding this comment.
🟢 Approval recommended
The change is a low-risk build-system adjustment that conditionally compiles optional examples without altering runtime code paths.
Pull request overview
Updates the Meson build logic for the example binaries so that Lottie “expression” examples are only included when the installed ThorVG build exposes expression support, allowing non-expression Lottie examples to still build successfully.
Changes:
- Removes expression-related example sources from the unconditional Lottie example list.
- Adds a separate compile/link probe for
tvg::LottieAnimation::expressions()and conditionally enables expression examples based on the result. - Improves build-time messaging to clarify when expression examples are skipped.
File summaries
| File | Description |
|---|---|
src/meson.build |
Splits Lottie example enablement into base Lottie vs. expression-capable Lottie, conditionally adding expression example sources. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hermet
requested changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for Lottie expression support separately from the base Lottie module so non-expression examples can still be built.