Skip to content

update rocksdb (rocksdb#432) - #854

Merged
ti-chi-bot[bot] merged 1 commit into
tikv:masterfrom
HunDunDM:hundundm/single-sst-pick
Jul 27, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
tikv:masterfrom
HunDunDM:hundundm/single-sst-pick

Conversation

@HunDunDM

@HunDunDM HunDunDM commented Jul 25, 2026

Copy link
Copy Markdown
Member

Description

Update RocksDB to include tikv/rocksdb#432.

This restores ldb manifest_dump --sst_file_number support, which is required by tikv-ctl bad-ssts to obtain the final live metadata of a corrupted SST file.

Related issue: tikv/tikv#19873

The RocksDB submodule is updated from:

  • 0cbfd4a7866b3a9448fbc2edabc79d55d0d80077

to:

  • 430d3f947e90636b00a2bf7dcc024d693f0e1fc1

No Rust API or FFI changes are required.

Summary by CodeRabbit

  • Chores
    • Updated the bundled RocksDB component to a newer revision.
    • No user-facing features or behavior changes are included.

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2026
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a1bfa100-f5de-47bb-8ec9-8e32ceace51d

📥 Commits

Reviewing files that changed from the base of the PR and between 66e1b77 and 124bfc0.

📒 Files selected for processing (1)
  • librocksdb_sys/rocksdb

📝 Walkthrough

Walkthrough

The pull request updates the librocksdb_sys/rocksdb submodule pointer from commit 0cbfd4a to 430d3f9. No application code or public declarations are changed.

Changes

RocksDB revision

Layer / File(s) Summary
Update embedded RocksDB revision
librocksdb_sys/rocksdb
The submodule pointer is updated from 0cbfd4a... to 430d3f9....

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: connor1996, v01dstar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the RocksDB submodule.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LykxSassinator

Copy link
Copy Markdown

Just a reminder: don't forget to update the GitHub submodule after tikv/rocksdb#432 (the prerequisite PR) is merged.

@ti-chi-bot

ti-chi-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jul 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-27 09:23:13.957494139 +0000 UTC m=+1828779.993589236: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 27, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit cab341c into tikv:master Jul 27, 2026
9 checks passed
@HunDunDM
HunDunDM deleted the hundundm/single-sst-pick branch July 27, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants