update rocksdb (rocksdb#432) - #854
Conversation
Signed-off-by: HunDunDM <hundundm@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the ChangesRocksDB revision
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Just a reminder: don't forget to update the GitHub submodule after tikv/rocksdb#432 (the prerequisite PR) is merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Description
Update RocksDB to include tikv/rocksdb#432.
This restores
ldb manifest_dump --sst_file_numbersupport, which is required bytikv-ctl bad-sststo obtain the final live metadata of a corrupted SST file.Related issue: tikv/tikv#19873
The RocksDB submodule is updated from:
0cbfd4a7866b3a9448fbc2edabc79d55d0d80077to:
430d3f947e90636b00a2bf7dcc024d693f0e1fc1No Rust API or FFI changes are required.
Summary by CodeRabbit