Skip to content

update rocksdb (rocksdb#435) - #858

Merged
ti-chi-bot[bot] merged 2 commits into
tikv:masterfrom
gengliqi:fix-ingest-allow-write
Aug 11, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
tikv:masterfrom
gengliqi:fix-ingest-allow-write

Conversation

@gengliqi

@gengliqi gengliqi commented Aug 11, 2026

Copy link
Copy Markdown
Member

Update rocksdb to include the bugfix tikv/rocksdb#435

Summary by CodeRabbit

  • Chores
    • Updated the underlying storage engine component to incorporate the latest upstream improvements.
    • No changes to the public API or user-facing functionality.

@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eaf730b3-91e4-4ce3-969e-2a50b372ddd4

📥 Commits

Reviewing files that changed from the base of the PR and between 63eeecd and 7957b31.

📒 Files selected for processing (1)
  • librocksdb_sys/rocksdb

📝 Walkthrough

Walkthrough

The librocksdb_sys/rocksdb submodule reference advances from commit 3ddc406f37c00c4002b202c4c52289f8723d1c24 to 0da2397eeb4b40b534ed586c13fb0b795438b2ce.

Changes

RocksDB submodule

Layer / File(s) Summary
Update submodule commit reference
librocksdb_sys/rocksdb
The pinned RocksDB commit changes to 0da2397eeb4b40b534ed586c13fb0b795438b2ce.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: connor1996, overvenus

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating the RocksDB submodule to include the referenced bugfix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-11 05:16:48.156350328 +0000 UTC m=+3109994.192445374: ☑️ agreed by hhwyt.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hhwyt, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 11, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 64a092f into tikv:master Aug 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants