browse: faster interactions, bounded watch memory, drop find-browse, add Aside provider#17
Merged
Merged
Conversation
click/fill/select and end-of-chain waited up to 2000ms for networkidle, taxing every interaction on polling/analytics pages. Capped to a shared NETWORK_SETTLE_MS (500ms); idle pages still resolve instantly (~4x faster per action on never-idle pages). watch mode retained every 5s snapshot (~125 MB/hr) though only the last is ever shown; now keeps last + count, with a reentrancy guard against overlapping snapshot runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
find-browse (a ~61 MB compiled Bun binary, ~122 MB uncompressed) had no runtime caller; the CLI resolves the browse binary by explicit path. Removed the source, its test, and the shim, and unwired it from the build, the runtime install manifest, the install smoke check, two CI workflows, the e2e test helpers, and the architecture doc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds the Aside AI browser to the GStack 2 browser-provider contract (kind: dedicated-ai-browser), so browser QA can route to the user's real logged-in browser via the aside CLI (structured snapshot, console logs via page.console.logs(), and network via page.cdp). Regenerated the six BROWSER-PROVIDERS.md and updated the provider-contract test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three targeted improvements to the local browse engine plus a new provider. Same Playwright core — no rewrite. Base is
codex/gstack-2, so the diff is exactly these 25 files (a PR tomainwould pull in the whole GStack 2 candidate).What changes
1. Faster interactions (
perf).click/fill/selectand end-of-chain waited up to 2000ms fornetworkidle, taxing every interaction on polling/analytics/websocket pages. Capped to a sharedNETWORK_SETTLE_MS(500ms). Idle pages still resolve instantly; only never-idle pages were paying. Measured ~4× faster per action (2030ms → 508ms).2. Bounded
watchmemory.watchretained every 5s snapshot (~125 MB/hr) even though only the last is ever displayed. Now keeps last + count, with a reentrancy guard so a slow snapshot can't stack overlapping runs. ~720× less retained.3. Removed the dead
find-browsebinary. A ~61 MB compiled Bun binary (~122 MB uncompressed) with no runtime caller — the CLI resolves the browse binary by explicit path. Removed source/test/shim and unwired it from the build, runtime install manifest, install smoke check, two CI workflows, e2e helpers, and the architecture doc.4. Aside browser provider (
feat). Added the Aside AI browser to the GStack 2 provider contract (kind: dedicated-ai-browser) so browser QA can route to the user's real logged-in browser via theasideCLI. Regenerated the sixBROWSER-PROVIDERS.mdand updated the provider-contract test.Testing
bun test): exit 0.find-browseremoval.watch125 MB/hr → 0.2 MB (720×); ~61 MB removed from the distribution.Not included
An unrelated Gemini benchmark-adapter fix is intentionally left out (stashed locally).
🤖 Generated with Claude Code
Summary by cubic
Make browse actions faster and cut watch-mode memory. Add the Aside browser provider and remove the unused
find-browsebinary.New Features
BROWSER-PROVIDERS.mdand updated the provider-contract test.Refactors
networkidlesettle afterclick/fill/selectand end-of-chain to 500ms; ~4× faster on never-idle pages.browse/dist/find-browsebinary and all wiring (build, runtime bundle, CI, tests, docs); ~61 MB trimmed from the distribution.Written for commit d3ed301. Summary will update on new commits.