Skip to content

fix(server): prevent dev toolbar injection into 204 responses #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hartslief wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix(server): prevent dev toolbar injection into 204 responses #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tina4_python/core/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2588,7 +2588,11 @@ def _stage_dev_toolbar_inject(ctx: DispatchContext) -> None:
Best-effort: a toolbar that fails to render must never break the response
it was decorating, so the whole thing is guarded.
"""
if not ctx.is_dev or not ctx.response.content_type:
if (
not ctx.is_dev
or not ctx.response.content_type
or ctx.response.status_code == 204
):
return None
if "text/html" not in ctx.response.content_type:
return None
Expand Down