shell: <video loop> on macOS - #17
Merged
Merged
Conversation
The macOS <video> overlay honoured controls/autoplay/muted but not `loop`. A looping <video> now builds an AVQueuePlayer driven by an AVPlayerLooper (declared as an external objcclass — it isn't in FPC's AVFoundation binding), replayed forever; the looper is retained in GVideoLoopers (keyed by src) and dropped when the <video> is torn down, else it deallocs and playback stops after one pass. Build-verified and compliance 219/219 (the shell change doesn't regress any snapshot); the loop plays only in a real window, so confirm live via `tools/tina4pascal deploy macos`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS
<video>overlay honoured controls/autoplay/muted but notloop. A looping<video>now uses an AVQueuePlayer + AVPlayerLooper (declared as an external objcclass — not in FPC's AVFoundation binding), retained inGVideoLoopersand dropped on teardown.Build-verified; compliance 219/219 (the shell change doesn't regress snapshots). The loop plays only in a real window — confirm live via
tools/tina4pascal deploy macos.🤖 Generated with Claude Code