benchmarking#21
Draft
danielmccannsayles wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds three small Go benchmarks—
diskwrite,netread, and a stdlib-onlynaivedownloader—to compare thehfCLI (huggingface_hub[hf_xet]) vs plain HTTPS and isolate network vs disk costs, informing removal ofhffrom modelwrap’s supply chain. Includes a probe to confirm if the HF path uses Xet, plus sample result TSVs and ago.modfor standalone builds.bench/naive: sequential downloader via Hub tree API +resolveURLs; records per-file network and disk times;--syncoption to fsync each file; optionalHF_TOKEN;run.shwritesnaive.tsv.bench/netread: streams each file toio.Discardto measure pure network throughput;run.shwritesnetread.tsv.bench/diskwrite: measures raw write and fsync throughput;run.shwritesdiskwrite.tsv.bench/README.md,writeup.md;bench/xet_probe.pymonkeypatchesxet_get/http_getand snapshots TCP peers with/withoutHF_HUB_DISABLE_XET.bench/results/*.tsv;bench/go.modfor isolated builds.Written for commit a665498. Summary will update on new commits.