feat: add Storybook with interactive component playground - #40
Conversation
|
3 outstanding code quality notes — same issues from previous review, new commits did not touch story files. Follow
Reviewed |
tomny-dev
left a comment
There was a problem hiding this comment.
The Storybook setup is green in CI, but #14's goal is coverage for all exported components and the current PR is incomplete against current main.
Current src/index.ts exports several component surfaces with no corresponding stories in #40, including at least: Label, Checkbox, Dropdown, PageContainer, PageHeader, SectionHeader, EmptyState, Inline/Stack, Stat/StatGroup, AuthCard, and the auth-page templates (SignInPage, SignUpPage, ForgotPasswordPage). The PR description also says "all 23 exported components" while its changed-file list only contains the older story set.
@tomny-roomote Please update #40 from current main and complete Storybook coverage for the currently exported component/component-group surface. Keep this docs/playground-only: do not redesign component APIs. Add focused stories that exercise the public variants/props of the missing exports, keep shared providers/decorators centralized, update the PR summary/counts to match reality, then rerun pnpm lint, pnpm test, pnpm build, and pnpm build-storybook. Preserve the existing green stories rather than rewriting them unnecessarily.
|
I'm on it. I routed this request into the existing PR task so follow-up work stays on one Roomote thread for this PR, and I'll keep updates here. See task |
|
Correction to my review above: |
Opened on behalf of tmyngu11@gmail.com. Updated PR body with complete component coverage table and correct story count (27 files). All 4 validations pass: lint ✅, test ✅, build ✅, build-storybook ✅ (217 modules). |
tomny-dev
left a comment
There was a problem hiding this comment.
Final manager pass is clean on 4b6f2a5. The React runtime/hook issues are fixed, remaining composition comments were advisory rather than #14 acceptance blockers, all review threads are resolved, and exact-head CI #261 passes including the Storybook build. Ready for manual merge.
|
Preview package published. Floating PR tag: pnpm add @tomny-dev/uzi@pr-40Exact published version: pnpm add @tomny-dev/uzi@0.3.0-pr.40.134.1.be5dfe7Published version: Use the PR tag to track the latest preview build for this PR. Use the exact version to pin a specific build. |
tomny-dev
left a comment
There was a problem hiding this comment.
Reviewed the expanded exact head 8b36738. README now documents local Storybook usage and deployment prerequisites, CI now builds Storybook, and the new Cloudflare Pages workflow follows the supported Wrangler Pages direct-upload pattern. Exact-head CI passes including the Storybook build, and Preview Publish completed successfully. Approved for merge; Cloudflare deployment itself will execute after merge to main once the documented Pages project and repository secrets exist.
|
CI workflow and README updates reviewed — no issues. 3 outstanding code quality notes from prior pass (inline-styled
Reviewed |
|
All code quality notes addressed — AuthCard now uses
Reviewed |
|
Label stories changes already covered in prior pass —
Reviewed |
tomny-dev
left a comment
There was a problem hiding this comment.
Revalidated exact head f0e470c951e3f5b46fbee77ce45cafd2a27d8695. The final Storybook composition cleanups are present, all review threads are resolved, and exact-head CI #273 plus Preview Publish #132 both pass. Ready for manual merge.
|
All code quality notes addressed. Only change since last review: removed unused
Reviewed |
tomny-dev
left a comment
There was a problem hiding this comment.
Revalidated exact head 29d48ea26c7ae7e40456be0efe38c0d4db9ebbad. The final dead Storybook preview import cleanup is present, all review threads are resolved, and exact-head CI #274 plus Preview Publish #133 both pass. Ready for manual merge.
Summary
Adds Storybook as Uzi's interactive component catalog and documents/deploys it as part of the library's normal development workflow.
pnpm storybookandpnpm build-storybookscripts.README.md.pnpm build-storybookpart of normal CI so Storybook regressions fail pull requests.Deploy Storybookworkflow that publishesstorybook-static/frommainto theuzi-storybookCloudflare Pages project usingCLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDrepository secrets.Deployment
The Pages deployment follows Cloudflare's Wrangler Pages direct-upload pattern. The Cloudflare API token must have Pages Write permission and the
uzi-storybookPages project must exist withmainas its production branch. A custom domain such asuzi.tomny.devcan then be attached to that project.Validation
pnpm lintpnpm testpnpm buildpnpm build-storybookCloses #14