Skip to content

docs(useStorageState): fix typo in korean docs#383

Open
joon623 wants to merge 2 commits into
toss:mainfrom
joon623:fix/typo-in-use-storage-state-ko-docs
Open

docs(useStorageState): fix typo in korean docs#383
joon623 wants to merge 2 commits into
toss:mainfrom
joon623:fix/typo-in-use-storage-state-ko-docs

Conversation

@joon623

@joon623 joon623 commented Jun 5, 2026

Copy link
Copy Markdown

Overview

Fix a Korean typo in useStorageState documentation.

Before: 이 값은 페이지룰 새로고침해도 유지되며
After: 이 값은 페이지를 새로고침해도 유지되며

Checklist

  • Did you write the test code?
  • Have you run yarn run fix to format and lint the code and docs?
  • Have you run yarn run test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6fb9740

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kimyouknow

Copy link
Copy Markdown
Collaborator

Hi, thank you for your contribution!

We made a significant change to the project direction (#302, #329): react-simplikit now focuses on platform-independent, pure state/logic hooks, and useStorageState is one of the deprecated browser-dependent hooks slated for removal. We're not accepting changes to deprecated hooks (including docs fixes), so we're closing this PR — consistent with earlier PRs like #264 and #360.

Contributions in other areas are always welcome — thank you!

@kimyouknow

Copy link
Copy Markdown
Collaborator

Hi @joon623, let me revise my earlier comment.

On reflection, this is a harmless typo fix that improves the existing Korean docs, so we're happy to take it after all. The only thing: since useStorageState is a deprecated hook slated for removal, we don't want this to trigger a version bump / npm release.

Could you drop the changeset (.changeset/quick-camels-hear.md) and keep only the docs change? Once the changeset is removed, I'll merge it.

Thanks again for contributing, and sorry for the back-and-forth!

@joon623

joon623 commented Jun 16, 2026

Copy link
Copy Markdown
Author

Makes sense to avoid a release for a deprecated hook — removed the changeset, docs change only now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants