Skip to content

Improvement#314

Open
slobglob wants to merge 1 commit into
traccar:masterfrom
slobglob:master
Open

Improvement#314
slobglob wants to merge 1 commit into
traccar:masterfrom
slobglob:master

Conversation

@slobglob

@slobglob slobglob commented Feb 1, 2018

Copy link
Copy Markdown

Added the report interval to the report in order to detect if the client has lost connection

Added the report interval to the report in order to detect if the client has lost connection
@tananaev

tananaev commented Feb 1, 2018

Copy link
Copy Markdown
Member

Can you please explain the use case.

@slobglob

slobglob commented Feb 1, 2018

Copy link
Copy Markdown
Author

@tananaev When the device sends a report, the device sends its report interval so the sever knows when to excpect the next report.
If the server doesn't get the report in that time (+some buffer) I know that the device went offline due to some reason (i.e. turned off or lost reception).

@tananaev

tananaev commented Feb 1, 2018

Copy link
Copy Markdown
Member

Are you planning to implement some modifications on the server side as well? What about iOS?

@slobglob

slobglob commented Feb 3, 2018

Copy link
Copy Markdown
Author

Maybe not right now, but possible to do that in the near future.
What do you think about that? Do you have any alternative to detect a GPS / Android loosing connection?

@tananaev

tananaev commented Feb 3, 2018

Copy link
Copy Markdown
Member

OK, we can merge when everything is ready. Also, the right way of implementing this would be to add a new parameter to the Position model. One more thing I suggest is renaming parameter to something shorter (e.g. "interval").

@slobglob

slobglob commented Feb 4, 2018

Copy link
Copy Markdown
Author

I'm not sure if that's correct, the interval isn't really a part of the Position model attributes (logically).
Just because we want to send it to the sever doesn't mean it has to be a part of the model.
The attribute name can definitely be changed.
And OK, we'll wait until all platforms are aligned.

@tananaev

tananaev commented Feb 4, 2018

Copy link
Copy Markdown
Member

I think it makes sense to send original interval value at the time when location was captured.

@slobglob

slobglob commented Feb 4, 2018

Copy link
Copy Markdown
Author

If you think this is the best approach we can do that, but I'm not sure that's the right way logically.
I'll keep you posted on the other platforms so we can merge everything at the same time.

What exactly do I need to change in the server?

@tananaev

tananaev commented Feb 4, 2018

Copy link
Copy Markdown
Member

We can either keep server as it is, but ideally we want to use interval for "unknown" status timeout.

@slobglob

slobglob commented Feb 5, 2018

Copy link
Copy Markdown
Author

Ok, I'll keep you updated. Thanks.

@garyvdm

garyvdm commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

I like this idea, and would find it useful.

@oliv3

oliv3 commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

@slobglob @garyvdm #348 implements this and more, if you want to try, feedback welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants