Skip to content

fix: stop reporting an AI-trace stats failure as 0ms latency #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrameAutomata wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: stop reporting an AI-trace stats failure as 0ms latency #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/app/controllers/ai_trace.controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package controllers

import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"sync"
Expand Down Expand Up @@ -162,8 +163,11 @@ func (a aiTraceController) FindByTraceName(c *gin.Context) {
return
}

// Stats are best-effort: the trace list still renders without them, so a
// failure here is reported rather than aborting the request.
stats, err := telemetry.AiTraceRepository.GetTraceNameStats(c, projectId, traceName, request.FromDate, request.ToDate)
if err != nil {
traceway.CaptureException(fmt.Errorf("failed to load ai trace stats (traceName=%s): %w", traceName, err))
stats = nil
}

Expand Down
2 changes: 1 addition & 1 deletion backend/app/repositories/telemetry/sqlite/ai_trace.repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ func (r *aiTraceRepository) GetTraceNameStats(ctx context.Context, projectId uui
WHERE project_id = :project_id AND trace_name = :trace_name AND recorded_at >= :from AND recorded_at <= :to
ORDER BY duration ASC`, params)
if err != nil {
return stats, nil
return nil, err
}

sortedDurations := make([]float64, len(durationRows))
Expand Down
Loading