Use transparency-dev/witness#1002
Merged
Merged
Conversation
roger2hk
approved these changes
Jun 12, 2026
Comment on lines
31
to
32
| logVerifier note.Verifier | ||
| signer note.Signer |
Contributor
There was a problem hiding this comment.
Are the logVerified and signer still required? It seems like they're now embedded in the witness struct.
Collaborator
Author
There was a problem hiding this comment.
signer will still be needed for responses to add-entries, I'll remove logVerifier for the moment...
| if err := mux.AddTarget(testOrigin, mock); err != nil { | ||
| t.Fatalf("AddTarget() failed: %v", err) | ||
| } | ||
| h := New(mux, nil) |
Contributor
There was a problem hiding this comment.
Passing the nil here would cause a panic if any test tries to call /add-checkpoint endpoint later.
Collaborator
Author
There was a problem hiding this comment.
Yup, I'll update this as the implementation of add-checkpoint progresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches over to directly using the witness implementation from
transparency-dev/witness.