Skip to content

fix: Strip trailing separators from --backend-directory path #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsiddharth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Strip trailing separators from --backend-directory path #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/python_be.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,6 +2419,16 @@ TRITONBACKEND_Initialize(TRITONBACKEND_Backend* backend)
#else
const std::string stub_executable_name = "triton_python_backend_stub";
#endif
// Remove any trailing path separators from the backend directory. Otherwise a
// value such as `--backend-directory=/opt/tritonserver/backends/` yields
// `/opt/tritonserver/backends//python`, which fails the equality check with
// the resolved backend `location` below and prevents the default Python
// backend from being detected.
// See: https://github.com/triton-inference-server/server/issues/6730
while (default_backend_dir_string.size() > 1 &&
default_backend_dir_string.back() == os_slash) {
default_backend_dir_string.pop_back();
}
// Check if `triton_python_backend_stub` and `triton_python_backend_utils.py`
// are located under `location`.
std::string default_python_backend_dir =
Expand Down