[Proof of Concept] Performance comparison with DualSPHysics - #167
Draft
efaulhaber wants to merge 55 commits into
Draft
[Proof of Concept] Performance comparison with DualSPHysics#167efaulhaber wants to merge 55 commits into
efaulhaber wants to merge 55 commits into
Conversation
Move check_cell_bounds() and construct_backends() to separate cell_lists_util.jl to share functionality between different cell lists.
- Move functions from cell_lists_util.jl to cell_lists.jl - Change dispatch in `supported_update_strategies()` - Change doc string of SHCL (SpatialHashingCellList)
- Add `@inbounds` in `push_cell_atomic!` - Improved type dispatch for `supported_update_strategies` - Clarified and cleaned up cell list initialization and emptying, - General code cleanup.
Add basic test for SVOV WIP to adapt FullGridCellList and GridNHS to use SVOV
Add basic unit test and CVOV to `test/neighborhood_search.jl` (tests are succeeding) Add update_grid!() and initialize_grid!()
…n in n_particles_per_cell.
…amework/PointNeighbors.jl into ef/rewrite-benchmarking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #151, #166, and #120.
This PR adds
CompactVectorOfVectorsbackend. It also completely removes thevaluesarray, which only works if the particles are all sorted according to cell index. This is also how DualSPHysics reach better performance. TheCompactVectorOfVectorsadded in Compact Vector of Vectors #120 itself with thevaluesarray is not faster than the regularDynamicVectorOfVectorsbackend.mapreduce_neighborfor this data structure to use the same neighborhood search algorithm as DualSPHysics.Note that I did not implement the fast GPU sorting that they have, so that we can benchmark the interactions kernel but not the total runtime, as the sorting will now use most runtime.
To be used together with trixi-framework/TrixiParticles.jl#1265.