Add plots for benchmarks of different machines to README - #169
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 15 15
Lines 792 792
=======================================
Hits 670 670
Misses 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I don't see the point in merging the code for the plots. You could just add them to an issue like we do it in TrixiParticles.jl and also include the numbers and code there. |
efaulhaber
left a comment
There was a problem hiding this comment.
Codex Review
The PR separates benchmark plotting from benchmark execution, adds machine-comparison plots to the documentation workflow, and embeds those generated plots in the README and docs. The split leaves the documented plotting workflow broken because its include no longer defines the plotting function.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
…rk/TrixiNeighborhoodSearch.jl into ef/machine-benchmark-plots
efaulhaber
left a comment
There was a problem hiding this comment.
Codex Review
The PR separates plotting from benchmark execution, adds CI-generated cross-machine benchmark plots to the documentation, and updates README benchmark and GPU-compatibility information. No concrete correctness or regression issues were found.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
Preview at https://trixi-framework.org/PointNeighbors.jl/previews/PR169/.
Note that the README.md doesn't show the new plots until merged into main, but they can be previewed on the starting page of the docs linked above.
This is the first PR revising the docs. In future PRs, I will