Add interface-aware surface pressure - #1283
Draft
svchb wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
===========================================
- Coverage 90.39% 80.33% -10.06%
===========================================
Files 138 139 +1
Lines 11322 11729 +407
===========================================
- Hits 10234 9423 -811
- Misses 1088 2306 +1218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack status
This draft depends on #1282 and the correction implementation layers #1284 and #1285. The validation-only #1286 is related but does not block this PR. The current branch still contains the pre-split dependency commits because the correction and surface-method changes overlap in the fluid-system constructors. After the dependencies merge, this branch will be rebased so the review delta is only commit
f16070658(14files).Summary
SurfacePressureDifference()support to WCSPH and EDAC.surface_activity.GradientCorrectionandMixedKernelGradientCorrectionand reject unsupported configurations.Numerical behavior
The difference operator removes the constant-pressure free-surface defect but is intentionally nonconservative where activity is nonzero. The validation records the expected momentum residual and confirms that it decreases under refinement.
Validation
39/39.42/42, including both supported surface-pressure corrections with zero RHS allocations.git diff --checkpasses.