Drafty draft - #1293
Draft
svchb wants to merge 314 commits into
Draft
Conversation
… in semidiscretization
- Updated the neighborhood search functions to utilize `foreach_interacting_system` for better interaction handling between systems. - Introduced new inline functions to streamline interaction checks and neighborhood search creation. - Enhanced the `Semidiscretization` struct to support custom interactions and ensure proper neighborhood search initialization. - Modified various fluid and boundary system functions to accommodate the new interaction model, ensuring that only relevant systems are considered during calculations. - Added tests to verify the behavior of the interaction matrix and ensure that disabled pairs skip configuration and neighborhood setup. - Improved the handling of custom interactions in the context of neighborhood searches, ensuring that they respect the defined interaction matrix.
- Replaced `foreach_interacting_system` with `foreach_system` in multiple fluid scheme files to simplify neighbor system interactions. - Updated pressure boundary calculations to use the new interaction method. - Adjusted predicted velocity and density calculations in implicit incompressible SPH to reflect the new interaction approach. - Modified shifting techniques to utilize the updated neighbor system iteration. - Enhanced surface normal calculations by adopting the new interaction method. - Updated tests to remove redundant checks related to interaction matrices and ensure proper functionality with the new interaction handling. - Improved clarity and maintainability of the code by removing unnecessary checks and simplifying interaction logic.
…n semidiscretization tests
# Conflicts: # src/callbacks/stepsize.jl
# Conflicts: # src/general/semidiscretization.jl
svchb
marked this pull request as draft
August 17, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlog after 1252:
merges #1252 and