Skip to content

Fix the sign of the quadratic term in ArtificialViscosityMonaghan - #1295

Open
efaulhaber wants to merge 2 commits into
trixi-framework:mainfrom
efaulhaber:fix-monaghan-viscosity-sign
Open

Fix the sign of the quadratic term in ArtificialViscosityMonaghan#1295
efaulhaber wants to merge 2 commits into
trixi-framework:mainfrom
efaulhaber:fix-monaghan-viscosity-sign

Conversation

@efaulhaber

@efaulhaber efaulhaber commented Aug 18, 2026

Copy link
Copy Markdown
Member

Based on #1086.

@efaulhaber efaulhaber self-assigned this Aug 18, 2026
@efaulhaber efaulhaber added the bug Something isn't working label Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.48%. Comparing base (a720b1d) to head (1de6e98).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...chemes/structure/total_lagrangian_sph/viscosity.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a720b1d) and HEAD (1de6e98). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a720b1d) HEAD (1de6e98)
total 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1295       +/-   ##
===========================================
- Coverage   90.39%   77.48%   -12.91%     
===========================================
  Files         138      138               
  Lines       11322    11299       -23     
===========================================
- Hits        10234     8755     -1479     
- Misses       1088     2544     +1456     
Flag Coverage Δ
total ?
unit 77.48% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber
efaulhaber force-pushed the fix-monaghan-viscosity-sign branch from 46715cb to a82df14 Compare August 18, 2026 13:38
@efaulhaber
efaulhaber force-pushed the fix-monaghan-viscosity-sign branch from a82df14 to 1de6e98 Compare August 18, 2026 14:02
@efaulhaber
efaulhaber marked this pull request as ready for review August 18, 2026 14:02
@efaulhaber
efaulhaber requested a review from svchb August 18, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant