Fix Instagram Reel and Story analytics by requesting views - #362
Merged
Merged
Conversation
…lays and impressions. A single retired metric name fails the whole insights request, so Reel and Story cards came back empty. Feed names were already valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plays(Reels) andimpressions(Stories). Asking for either fails the whole request, so the post card comes back empty.viewsinstead, keep the valid feed metric set, and map labels through the existing analytics translations.viewsinstead of retiredplaysfor Reels #319, which only renamed Reelplaysand left Story broken.Test plan
php artisan test --compact tests/Feature/Services/Social/InstagramAnalyticsTest.php