Skip to content

[chore][MCP] Clean up configuration comments#349

Merged
arnold-retool merged 1 commit into
mainfrom
arnold/cleanup-mcp-comments
Jul 20, 2026
Merged

[chore][MCP] Clean up configuration comments#349
arnold-retool merged 1 commit into
mainfrom
arnold/cleanup-mcp-comments

Conversation

@arnold-retool

@arnold-retool arnold-retool commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add copyable MCP enablement examples for chart-managed and existing-secret setups
  • streamline the MCP configuration comments while retaining OAuth and ingress guidance
  • remove redundant maintainer and rendered-manifest comments
  • document the standalone git server default more accurately
  • bump the chart version to 6.11.11

No chart configuration values changed apart from the required chart version bump.

Testing

  • helm lint charts/retool
  • helm lint charts/retool -f charts/retool/ci/test-mcp-enabled-option.yaml
  • rendered the minimal chart-managed-token example
  • rendered the explicit-host and existing-secret example, verifying both workloads reference the same token
  • verified values.yaml and charts/retool/values.yaml remain identical
  • git diff --check

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — purely comment and version-bump changes with no functional modifications.

All seven changed files contain only comment rewrites or the chart version bump. No template logic, default values, or secret wiring was touched. The author verified the examples by rendering them and ran helm lint against the CI test fixture.

No files require special attention.

Important Files Changed

Filename Overview
charts/retool/Chart.yaml Patch version bump from 6.11.10 to 6.11.11, consistent with the comment-only changes in this PR.
charts/retool/templates/_helpers.tpl Two helper-function comments condensed; no logic changes.
charts/retool/templates/deployment_backend.yaml Four-line MCP introspection-token comment replaced with a single-line summary; no template logic changed.
charts/retool/templates/deployment_mcp.yaml Git-server URL routing comment condensed; no template logic changed.
charts/retool/templates/ingress.yaml Removed two duplicate inline comments about MCP path ordering; routing logic and path ordering are unchanged.
charts/retool/values.yaml MCP comment block rewritten: adds copyable quick-start examples, condenses existing field descriptions, and consolidates path-ordering guidance for external ingress users. No default values changed.
values.yaml Identical changes to charts/retool/values.yaml, keeping the two files in sync as documented.

Reviews (5): Last reviewed commit: "[chore][MCP] Clean up configuration comm..." | Re-trigger Greptile

@arnold-retool
arnold-retool force-pushed the arnold/cleanup-mcp-comments branch from 72b6a0b to b0b4503 Compare July 20, 2026 21:10
Comment thread charts/retool/values.yaml Outdated
Comment thread charts/retool/values.yaml Outdated
Comment thread charts/retool/values.yaml Outdated
@arnold-retool
arnold-retool force-pushed the arnold/cleanup-mcp-comments branch 4 times, most recently from 023eb43 to b1e532d Compare July 20, 2026 21:59
@arnold-retool
arnold-retool force-pushed the arnold/cleanup-mcp-comments branch from b1e532d to 39b8464 Compare July 20, 2026 22:01

@lukefoster11 lukefoster11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

arnold-retool commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 20, 11:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 20, 11:27 PM UTC: @arnold-retool merged this pull request with Graphite.

@arnold-retool
arnold-retool merged commit f3687de into main Jul 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants