You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Safe to merge — the change is additive (new env var only when MCP is enabled), override detection covers all three env-setting paths, and the helper follows the exact same pattern already used for agent sandbox env vars.
The new helper correctly gates injection on mcp.enabled, de-duplicates against all three override mechanisms using established Helm patterns, and defaults gracefully when mcp.service is absent. The nindent 10 on empty output is the same pattern used by the adjacent retool.agentSandbox.backendEnvVars call. Both values.yaml files are kept in sync and the docs accurately describe the new automatic behavior.
Files Needing Attention: No files require special attention.
Important Files Changed
Filename
Overview
charts/retool/templates/_helpers.tpl
Adds retool.mcp.backendEnvVars helper that auto-injects MCP_SERVICE_INGRESS_DOMAIN for MCP-enabled installs, with correct override detection across all three env-setting mechanisms (env, environmentSecrets, environmentVariables)
charts/retool/templates/deployment_backend.yaml
Single-line inclusion of the new retool.mcp.backendEnvVars helper, positioned correctly in the env block alongside other service-discovery env vars
charts/retool/values.yaml
Documentation updated to reflect the charts new automatic MCP_SERVICE_INGRESS_DOMAIN injection, replacing the manual env block example with a description of the auto-config and override path
values.yaml
Mirror of charts/retool/values.yaml documentation update; kept in sync as required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing