Skip to content

Add PCB keepout outlines - #736

Merged
ShiboSoftwareDev merged 4 commits into
mainfrom
codex/add-pcb-keepout-path
Aug 27, 2026
Merged

Add PCB keepout outlines#736
ShiboSoftwareDev merged 4 commits into
mainfrom
codex/add-pcb-keepout-path

Conversation

@ShiboSoftwareDev

@ShiboSoftwareDev ShiboSoftwareDev commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why

Altium can define a keepout as a stroked Track or Arc boundary. The existing pcb_keepout element only represented rectangles and circles, so these boundaries could not be preserved without changing their geometry or meaning.

These boundaries are outlines rather than polygons: many are open, and their interior is not a filled keepout region.

What changed

  • Extend the existing pcb_keepout element with shape: "outline"
  • Store its geometry in outline and preserve its stroke_width
  • Require at least two outline points

This does not introduce another Circuit JSON element. It adds the missing outline geometry to the existing keepout element.

Validation

  • bun test --max-concurrency=1 — 316 pass
  • bun run build
  • bunx tsc --noEmit
  • bun run lint:zod
  • bun run check-snake-case
  • Biome formatting check on both changed files

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this violates ambiguous suffix rules

it there exists pcb_keepout, then you cannot introduce a specific suffix.

@ShiboSoftwareDev ShiboSoftwareDev changed the title Add path-shaped PCB keepouts Add PCB keepout outlines Aug 27, 2026
@ShiboSoftwareDev
ShiboSoftwareDev merged commit 10da6e5 into main Aug 27, 2026
4 checks passed
@ShiboSoftwareDev
ShiboSoftwareDev deleted the codex/add-pcb-keepout-path branch August 27, 2026 20:09
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants