feat: support castellated holes in board outlines - #3439
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
force-pushed
the
feat/board-outline-castellated-holes
branch
from
August 26, 2026 05:40
88c43fa to
0c36def
Compare
seveibar
force-pushed
the
feat/board-outline-castellated-holes
branch
from
August 26, 2026 06:02
0c36def to
25da799
Compare
seveibar
force-pushed
the
feat/board-outline-castellated-holes
branch
from
August 26, 2026 18:26
25da799 to
4d56669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isCastellatedHoleboard outline points as circular plated holes usingholeDiameterandpadDiameterconnectsTotargets@tscircuit/propsto0.0.636for the public board outline point schemaUses the schema introduced by tscircuit/props#816.
Test plan
bun test tests/components/normal-components/board-castellated-holes.test.tsx tests/components/normal-components/board-castellated-holes-panel-layout.test.tsxbun test tests/features/group-ports/*.test.tsx tests/components/normal-components/board-*.test.tsxbunx tsc --noEmitbun run buildbun test --timeout 30000(1,453 passed, 40 skipped, 0 failed)