Fix pushbutton KiCad hole parity#683
Open
rushabhcodes wants to merge 1 commit into
Open
Conversation
seveibar
reviewed
Jul 3, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
the plated holes are worse now imo- there is almost no plating- i don't agree with kicad's version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idfor the pushbutton drill diameterodfor the outer pad diameterWhy
The pushbutton generator ignored
odand derived the outer diameter asid × 1.5. The parity fixture therefore inflated the drill diameter to obtain the correct 2 mm outer pad, leaving every drill larger than the matching KiCad footprint.Impact
Pushbutton footprints now honor both diameter parameters independently, and the parity fixture matches KiCad’s 1.1 mm drill with a 2 mm outer pad.
Validation
bun test tests/pushbutton.test.ts tests/kicad-parity/pushbutton_kicad_parity.test.tsbun run build