Conversation
…tionManager Bump Terminal.Gui 2.4.10 -> 2.5.0-tig-remove-cm-followup.1, a preview build of tui-cs/Terminal.Gui#5416 (ConfigurationManager removal), TEMP-vendored in ./local_packages via a "tgui-pr-5416" nuget.config source until 2.5.x ships on nuget.org. API migration: - ConfigurationManager.AppName/Enable(ConfigLocations.All) -> new TuiConfigurationBuilder("<cmdlet>").ApplyToStaticFacades() in OutConsoleGridView and ShowObjectView (config is now also auto-applied at assembly load via TuiConfigurationBuilder.Shared). - Drop the redundant Enable call in OutGridViewWindowIntegrationTests. Part of the v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). Pattern precedent: tig/winprint#272. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
The vendored Terminal.Gui 2.5.0-tig-remove-cm-followup.1 was built from tui-cs/Terminal.Gui@93c3b3d40, five commits behind the PR 5416 head, and predated that branch's ultrareview fixes. In that build ./.tui/ config paths resolve against AppContext.BaseDirectory (pwsh's install directory for this module), so the GlobalCurrent and AppCurrent config locations that 2.4.x resolved against the process working directory were silently dead - contradicting the port's own comments. Test-first fixes: - New TuiConfigurationTests pin CWD-relative discovery of ./.tui/config.json and ./.tui/Out-ConsoleGridView.config.json (both failed against followup.1), explicit-currentDirectory discovery, and no-throw fallback on malformed config files. - Re-vendor Terminal.Gui 2.5.0-tig-remove-cm-followup.2 built from the PR 5416 head (tui-cs/Terminal.Gui@e8aba4230) with an explicitly set version, so the stale-cache collision GitVersion caused (same followup.1 version for different commits) cannot recur. - Pass the PowerShell session's current filesystem location (SessionState.Path.CurrentFileSystemLocation) through ApplicationData to TuiConfigurationBuilder's new currentDirectory parameter: pwsh does not sync the process working directory with Set-Location, so without this ./.tui/ discovery used wherever pwsh was launched, not where the user cd'd. Verified: Invoke-Build -Configuration Release Clean, Build, Test - 82/82 xUnit, 20/20 Pester, 26 assemblies packaged; clean-cache restore from ./local_packages; in-host pwsh probe confirms ./.tui/<cmdlet>.config.json now applies from the session's cd location. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
Swap the 5416 preview nupkg for nuget.org Terminal.Gui 2.5.0-develop.55. Delete local_packages/ and the extra tgui-pr-5416 nuget.config source. Co-authored-by: Tig <tig@users.noreply.github.com>
cursor
Bot
changed the title
Swap the 2.5.0-develop.55 pin for nuget.org 2.5.0-beta.1. Co-authored-by: Tig <tig@users.noreply.github.com>
cursor
Bot
changed the title
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins public
Terminal.Gui 2.5.0-develop.55from nuget.org so PSTui can be validated ahead of the v2.5.0 tag. Before merging, once stable 2.5.x is on nuget.org:Directory.Packages.propsDo not vendor a local nupkg. The 5416 preview feed (
local_packages/,tgui-pr-5416nuget.config source) is already gone. The remainingnuget.configis the develop nuget.org source.Summary
Retargets this PR from the vendored
2.5.0-tig-remove-cm-followup.2pin to public2.5.0-develop.55as part of tui-cs/Terminal.Gui#5630 Workstream 4.API breaks already fixed (kept):
ConfigurationManager.Enable/ConfigLocations→TuiConfigurationBuilderinOut-ConsoleGridViewandShow-ObjectTree, passing the PowerShell session filesystem location ascurrentDirectory(pwsh does not sync process CWD withSet-Location)TuiConfigurationTestspin CWD-relative./.tui/discoveryNo
View.TextorIAcceptTargethits.Validation
CI on this head:
dotnetwindows/macos/ubuntu green.Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630.