Add encryption to namespace copy params#242
Closed
JevonCowell wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hey @JevonCowell, thanks for the PR. This idea makes sense. However, this SDK is automatically generated from our OpenAPI spec, so we can't accept this change as is! We need to update the upstream API spec instead. Let me see about getting that done for you. |
Author
|
Done in #244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add optional encryption support to NamespaceCopyFromParams so standalone copy operations can specify namespace encryption directly.
Why?
Users can currently work around this by using NamespaceWriteParams.copyFromNamespace(...) with top-level encryption(...), but adding encryption to NamespaceCopyFromParams makes the standalone copy operation support this convenience directly.
Risk evaluation (required)
Low. This adds an optional request body field and mirrors the existing NamespaceWriteParams encryption API. Existing requests without encryption continue to serialize the same required source_namespace fields.
How will the change get rolled back? (optional)
Revert this pull request.
Verification