Skip to content

Add encryption to namespace copy params#242

Closed
JevonCowell wants to merge 1 commit into
turbopuffer:mainfrom
JevonCowell:add-encryption-to-copy-from-params
Closed

Add encryption to namespace copy params#242
JevonCowell wants to merge 1 commit into
turbopuffer:mainfrom
JevonCowell:add-encryption-to-copy-from-params

Conversation

@JevonCowell

Copy link
Copy Markdown

What?

Add optional encryption support to NamespaceCopyFromParams so standalone copy operations can specify namespace encryption directly.

Why?

Users can currently work around this by using NamespaceWriteParams.copyFromNamespace(...) with top-level encryption(...), but adding encryption to NamespaceCopyFromParams makes the standalone copy operation support this convenience directly.

Risk evaluation (required)

Low. This adds an optional request body field and mirrors the existing NamespaceWriteParams encryption API. Existing requests without encryption continue to serialize the same required source_namespace fields.

How will the change get rolled back? (optional)

Revert this pull request.

Verification

  • ./gradlew :turbopuffer-java-core:test --tests 'com.turbopuffer.models.namespaces.NamespaceCopyFromParamsTest'
  • ./scripts/format
  • git diff --check

@benesch

benesch commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Hey @JevonCowell, thanks for the PR. This idea makes sense. However, this SDK is automatically generated from our OpenAPI spec, so we can't accept this change as is! We need to update the upstream API spec instead. Let me see about getting that done for you.

@JevonCowell

Copy link
Copy Markdown
Author

Done in #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants