[pull] master from php:master#1069
Merged
Merged
Conversation
These millions of iterations don't seem to be necessary to trigger the original bug.
* PHP-8.5: Fix performance of gh22443.phpt
…build Without this, executor globals vary in size and offsets for C vs. C++, which leads to issues since GH-22287.
* PHP-8.2: [skip ci] Add -DZEND_VERIFY_TYPE_INFERENCE to CXXFLAGS for variation build
* PHP-8.3: [skip ci] Add -DZEND_VERIFY_TYPE_INFERENCE to CXXFLAGS for variation build
* PHP-8.4: [skip ci] Add -DZEND_VERIFY_TYPE_INFERENCE to CXXFLAGS for variation build
* PHP-8.5: [skip ci] Add -DZEND_VERIFY_TYPE_INFERENCE to CXXFLAGS for variation build
zend_call_function invokes an internal callee's handler directly, with no VM frame and without the stack-limit check the interpreter runs at its call opcodes. An internal function that recurses through zend_call_function, such as a self- or mutually-attached SPL iterator, never yields back to the VM, so nothing bounds the recursion and the C stack overflows into a SEGV. Check zend_call_stack_overflowed() before pushing the call frame and raise the usual "Maximum call stack size reached" error on overflow. Running the check ahead of the frame setup keeps the error path free of teardown. Fixes GH-15672 Fixes GH-15911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )