[pull] master from ruby:master#1186
Merged
Merged
Conversation
``` Results — YJIT enabled: block.call vs yield, before/after ┌──────────────────────┬─────────────────────┬────────────────────┬────────────┬ │ operation │ before (2a23415) │ after (dd4711e727) │ speedup │ ├──────────────────────┼─────────────────────┼────────────────────┼────────────┼ │ yield (control) │ 58.57M i/s │ 58.56M i/s │ — (stable) │ ├──────────────────────┼─────────────────────┼────────────────────┼────────────┼ │ call (0 args) │ 32.95M i/s │ 57.37M i/s │ 1.74× │ ├──────────────────────┼─────────────────────┼────────────────────┼────────────┼ │ yield(1,2) (control) │ 47.25M i/s │ 51.64M i/s │ — │ ├──────────────────────┼─────────────────────┼────────────────────┼────────────┼ │ call(1,2) (2 args) │ 31.25M i/s │ 51.62M i/s │ 1.65× │ └──────────────────────┴─────────────────────┴────────────────────┴────────────┴ ```
This PR fixes a comment that calls ZJIT basic blocks extended. They have been traditional basic blocks since #16888.
It was [previously][1] moved from C to Ruby, but the doc on the Ruby method was copied from `#lock` while the correct doc was left in C. [1]: 07b2356
We renamed `rpo` to `reverse_post_order` so rename this one to match as well.
The old name is a bit of a misnomer now since it's not saving just the PC anymore. It's still one write, but it's the JITFrame pointer.
This is a footgun, less bad than the C version, whereby an `assert!` could reasonably be changed into a `debug_assert!` and cause a problem because the condition no longer executes in release builds. This one would probably be instantly noticeable, but still.
Keep the functions together (not split in HIR/codegen) and in a more reasonable module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )