Make execution failures fail loudly: name the executable and exit code in the error Notice#447
Open
nelsonlove wants to merge 1 commit into
Open
Make execution failures fail loudly: name the executable and exit code in the error Notice#447nelsonlove wants to merge 1 commit into
nelsonlove wants to merge 1 commit into
Conversation
…Error!' Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a code block fails to run, the current toast just says "Error!" — and when the failure is "executable not on PATH" (very common on macOS, where GUI apps get the bare launchd PATH without Homebrew), the user gets no hint at what went wrong or how to fix it.
This PR makes
NonInteractiveCodeExecutorfailures actionable:Execute Code: 'sbcl' was not found. Set the full path to the executable in the plugin settings.(10s toast)Execute Code: process exited with code N. See the output below the code block.errorevent (e.g. ENOENT whenshell: false) →Execute Code: failed to start 'cmd': <message>Changes
handleChildOutputgains an optional trailingcmd?: stringparam (backwards-compatible; callers that don't pass it get generic wording)NonInteractiveCodeExecutor(incl. the gcc compile/execute path),ClingExecutor, andPowerShellOnWindowsExecutorpass the command throughTesting
npm run buildpasses (tsc + esbuild)🤖 Generated with Claude Code