Skip to content

Fix compounding code injection on repeated runs of the same block #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelsonlove wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compounding code injection on repeated runs of the same block #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/RunButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ async function handleExecution(block: CodeBlockContext) {
const s: ExecutorSettings = block.outputter.settings;

button.className = disabledClass;
block.srcCode = await new CodeInjector(app, s, language).injectCode(srcCode);
// Run against a copy of the block context: the context is shared between
// runs of the same rendered block, so writing the injected code back into
// it would compound pre/post/import injections on every re-run.
block = { ...block, srcCode: await new CodeInjector(app, s, language).injectCode(srcCode) };

switch (language) {
case "js": return runCode(s.nodePath, s.nodeArgs, s.jsFileExtension, block, { transform: (code) => macro.expandJS(code) });
Expand Down