Address openid session crashes on invalid input#592
Open
jonasbardino wants to merge 3 commits into
Open
Conversation
especially the input validation ones. Show a generic error page and only write log warnings rather than errors in that case. Check the openid library could in fact decode user query to a request before using the result in order to avoid some NoneType object attribute errors when it couldn't.
Removed unused parent openid module import and left it to the openid.x module imports to fail hard if missing.
…o avoid redundancy.
jonasbardino
added
the
battle-tested
Contributor
Author
|
UPDATE: the above turned out to be my browser settings preventing full page load and now I can see that it's just one of the old lint errors covered in #338. |
jonasbardino
marked this pull request as ready for review
July 15, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #589 with more robust handling of various errors and especially the input validation ones. Show a generic error page and only write log warnings rather than errors in that case.
Check the openid library could in fact decode user query to a request before using the result in order to avoid some NoneType object attribute errors when it couldn't.
Some generic lint fixes and polish of error messages to properly show support email.