Performance optimizations and leak fixes for Activity Tracker - #1
Performance optimizations and leak fixes for Activity Tracker#1unfoldingdimensions wants to merge 1 commit into
Conversation
- Implemented `get_input_history_aggregated` to use SQL `GROUP BY` for massive reduction in IPC overhead (476k rows -> 169 rows). - Added `start()` and `stop()` lifecycle management to `InputMonitor` to prevent thread leaks. - Implemented Windows-specific thread shutdown using `PostThreadMessageW(WM_QUIT)`. - Optimized `IconSystem` initialization to use `System::new()` instead of `System::new_all()`, avoiding unnecessary system info gathering. - Fixed a handle leak in `windows_api.rs` by explicitly closing `OpenProcess` handles. - Ensured cross-platform compilation compatibility. Co-authored-by: unfoldingdimensions <242757459+unfoldingdimensions@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change addresses critical performance issues and resource leaks identified in the application.
get_input_historycommand previously fetched all raw input events, causing massive memory spikes and IPC bottlenecks. It now uses a server-side SQL aggregation query (get_input_history_aggregated) to fetch pre-bucketed data, reducing the payload size by over 99%.InputMonitornow has a proper shutdown mechanism. On Windows, it posts aWM_QUITmessage to break therdevmessage loop, preventing zombie threads during app reloads.IconSystemno longer initializes withSystem::new_all(), significantly reducing startup CPU usage.windows_api::get_process_namenow properly closes process handles, fixing a leak that would accumulate thousands of handles over time.PR created automatically by Jules for task 9758533704777785750 started by @unfoldingdimensions